On Tue, Mar 28, 2017 at 07:37:54PM -0400, Ronald S. Bultje wrote:
> Fixes a reported (but false) race condition in tsan for fate-apng.
> ---
> libavcodec/pngdec.c | 39 +++++++++++++++++++--------------------
> 1 file changed, 19 insertions(+), 20 deletions(-)
>
> diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
> index a4eb6cc..bbb9610 100644
> --- a/libavcodec/pngdec.c
> +++ b/libavcodec/pngdec.c
> @@ -45,7 +45,7 @@ typedef struct PNGDecContext {
> ThreadFrame last_picture;
> ThreadFrame picture;
>
> - int state;
> + int state, pstate;I think its clearer if both variable names differ from the prior one also the constants should be renamed consistently with the field names they are used with. Otherwise its a bit confusing what constant belongs to which state variable thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
