Thanks for those comments -- I'll get rid of the strlen in the upcoming patch but, Nicolas, you lost me there.
Anyway, this patch only does half the job -- I have a new one that is unfortunately larger, but has taken prior advice to break cookies into dicts. On Thu, Mar 30, 2017 at 4:12 PM, Nicolas George <geo...@nsup.org> wrote: > Le decadi 10 germinal, an CCXXV, Alexander Strasser a écrit : >> If expiry is zero terminated and you are going through it one byte at a time, >> you could omit the strlen call and just check if expiry[i] is non zero. >> >> It's maybe the more common idiom too. > > On the other hand, code that does not need a 0-terminated string is more > generic. > > I am thinking of the ideas I posted a few months ago about reworking the > options system to avoid escaping hell. Parsers for various types must be > able to work in the middle of strings with foreign delimiters. Code that > is already capable of working in the middle of a string would be easier > to integrate. > > Of course, all this is in the far future. I will not insist on all new > code to be able to work like that, but I would like it nonetheless. And > if it is already written that way, let us keep it. > > All in all, 0-terminated strings were a terrible terrible idea. > > Regards, > > -- > Nicolas George > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- "The mark of an immature man is that he wants to die nobly for a cause, while the mark of the mature man is that he wants to live humbly for one." --W. Stekel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel