On 4/5/2017 11:05 AM, Steven Liu wrote: > 2017-04-03 20:32 GMT+08:00 Nicolas George <geo...@nsup.org>: > >> Le quartidi 14 germinal, an CCXXV, Steven Liu a écrit : >>> change name from av_strreplace to av_strireplace >>> Use AVBprint to implement av_strireplace >>> add av_strireplace test case TEST_STRIREPLACE >>> >>> Signed-off-by: Steven Liu <l...@chinaffmpeg.org> >>> --- >>> libavutil/avstring.c | 76 +++++++----------------------- >> ---------------- >>> libavutil/avstring.h | 2 +- >>> libavutil/tests/avstring.c | 16 ++++++++++ >>> 3 files changed, 28 insertions(+), 66 deletions(-) >> >> This version looks fine to me. >> >> Maybe wait a little more for advice about the rename and the whole >> thing. >> >> Thanks. >> >> -- >> Nicolas George >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> > ping
You can't rename the function. It's already in the 3.3 branch. This is one of the reasons why giving people enough time for reviews is a must before pushing new public symbols. The rest should be ok since Nicolas reviewed it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
