On Wed, Apr 05, 2017 at 02:03:00 +0200, Marton Balint wrote: > -static int process_work_frame(AVFilterContext *ctx, int stop) > +static int process_work_frame(AVFilterContext *ctx, int filter_frame)
Just from a level of confusion, I don't find it smart to name a variable (albeit a local one) the same as an existing function. > + return filter_frame ? 0 : ff_request_frame(ctx->inputs[0]); The unknowing code reader (as myself) could interpret this as the check for a function pointer. Only because I know functions of the name filter_frame() are often used in filters. Yeah, silly me. Just nitpicking a bit, perhaps quite irrelevant, Moritz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel