On Thu, Apr 06, 2017 at 07:35:04PM +0200, Nicolas George wrote: > Le septidi 17 germinal, an CCXXV, Michael Niedermayer a écrit : > > A comment explaining this (if you agree that the issue is real and not > > some mistake of understanding something on my side) > > would be a good idea. > > could be confusing otherwise and lead to misunderstandings > > I am sorry, I have no idea what kind of comment you would like. > > Once again, this patch is just renaming a variable to have a name > similar to how it is used. It does not change the logic of the current > code, and if anything it makes it clearer. I do not think adding a > comment belongs here.
Currently the packet duration is assigned to a variable called duration After your patch it is assigned to a variable called duration_dts Someone reading duration_dts = pkt->duration; will have an idea what pkt->duration is, our stuff is often documented through code. If a line of code gives a incorrect impression, it should be documented to avoid it leading to misunderstandings. I assume here that i didnt miss something all along and this is actually buggy Also duration_dts should be documented, what does it exactly mean the difference between teh current and next dts ? if so it should probably also be changed to int64_t, thats not a issue in this patch, but trivial to fix and you already work on this. If i fix it i would break your patchset if i apply it before and ill forget to do it later ... [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
