On 4/20/2017 3:58 PM, Michael Niedermayer wrote: > On Thu, Apr 20, 2017 at 03:02:54PM +0100, Derek Buitenhuis wrote: >> The original author apparently never read the documentation for snprintf, >> or even tested that the output was correct.
> This statement does not belong in a commit message. > Its insulting to whoever the author is and may not even be true. Removed. However it /definitely/ was not tested properly. New message: Output was apparently not tested for correctness. Passing overlapping memory to snprintf causes undefined behavior, and usually resulted in only the very last timestamp being written to metadata, and not a list at all. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel