On 4/24/2017 6:48 PM, KongQun Yang wrote: > -- KongQun Yang (KQ) > > On Fri, Apr 21, 2017 at 4:49 PM, Hendrik Leppkes <h.lepp...@gmail.com> > wrote: > >> On Sat, Apr 22, 2017 at 1:25 AM, Hendrik Leppkes <h.lepp...@gmail.com> >> wrote: >>> This brings our generation of the vpcC box up to date to version 1.0 >>> of the VP Codec ISO Media File Format Binding. >>> >>> Specifically, color/transfer properties are now written with values >>> based on ISO/IEC 23001-8, which is the same reference specification the >>> AVColor* enumerations are based on. >>> --- >>> libavformat/movenc.c | 3 ++- >>> libavformat/vpcc.c | 55 +++++------------------------- >> ---------------------- >>> 2 files changed, 7 insertions(+), 51 deletions(-) >>> >> >> Actually I should probably update the main commit message to mention >> that its v1.0 and not a draft any longer? >> > > SGTM. Should we remove the experimental check as well: > https://github.com/FFmpeg/FFmpeg/blob/b905ba5bc18c89c7fccd8621795755644442ef19/libavformat/movenc.c#L5989 > ?
IMO yes, assuming the vpcc boxes generated after this patch are 100% v1.0 compliant. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
