On 27 July 2017 at 09:38, Ivan Kalvachev <ikalvac...@gmail.com> wrote:
> On 7/27/17, Rostislav Pehlivanov <atomnu...@gmail.com> wrote: > > On 26 July 2017 at 15:56, Ivan Kalvachev <ikalvac...@gmail.com> wrote: > > > >> + if (ARCH_X86 && CONFIG_OPUS_ENCODER) > >> + ff_opus_dsp_init_x86(s); > >> > > > > Just change it to > > + if (ARCH_X86) > > > > The init function is named opus_dsp, so it'll get used to other opus > > things, not just the encoder. > > But at the moment it does not. > I do prefer to leave that task for the one that > adds opus decoder functions. > > Also this change alone would break compilation, since > it also requires changing the libavcodec/x86/Makefile > and adding the guard inside the opus_dsp_init.c > > Another option is to have "opus_enc_dsp_init.c" and call > the function "ff_opus_enc_dsp_init_x86()". > > Do tell me which option do you prefer > and do you insist on v7 just for that. > > > The assembly code looks fine to me, but other people will have to take a > > look at it in case I'm missing something. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > The former, but that can be changed later after pushing _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel