On 7/29/17, Dominik 'Rathann' Mierzejewski <domi...@greysector.net> wrote: > On Saturday, 29 July 2017 at 00:20, Hendrik Leppkes wrote: >> On Fri, Jul 28, 2017 at 12:07 PM, James Le Cuirot <ch...@gentoo.org> >> wrote: > [...] >> > This Makefile snippet allows libffmpeg to be created without the help >> > of Chromium's build system. It uses the CONFIG_SHARED variable to >> > decide whether to link the FFmpeg libraries statically or >> > dynamically. In the latter case, libffmpeg is just a wrapper with no >> > symbols of its own. > [...] >> I don't think ffmpeg is the right place to maintain special makefiles >> for Chromium. > > I concur. Instead, Chromium should be fixed to link against individual > FFmpeg libraries properly.
To be honest, I do not find the combined library such a bad idea. Actually I think that going this way has been discussed before, long before Chromium existed. For example, if you have to dlopen ffmpeg libs, it takes a lot of care to load all the interlinked libraries in the correct order. And imagine the fun if you have multiple versions installed. Having one front-end to load all correct libraries is logical improvement and simplification. This is why Chromium has done it on their own. This is why FFmpeg should do it too. Also, the changes are isolated to a separate file in the build system, it should not interfere with normal build process or merges. I do however object on hardcoding "chromium" codepaths in it. Best Regards. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
