On Sat, Aug 19, 2017 at 5:40 PM, Rostislav Pehlivanov <atomnu...@gmail.com> wrote: > On 19 August 2017 at 16:10, Ivan Kalvachev <ikalvac...@gmail.com> wrote: > >> Using named define properly documents the code paths. >> It also avoids passing additional numbered arguments through >> multiple levels of macro templates. >> >> The suffix handling is done by concatenation, like in >> other asm functions and avoid having two separate >> "cglobal" defines. >> >> --- >> I have to point few things out. >> >> commit f386dd70acdc81d42d6bcb885d2889634cdf45b7 >> "opus_pvq_search: only use rsqrtps approximation on CPUs with avx" >> was rushed hack job: >> > > Well, your original patch was unpolished, so there's that. > >
You reviewed it, approved it, and pushed it. You only have yourself to blame in that case. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
