On 9/27/17, Tobias Rapp <t.r...@noa-archive.com> wrote: > On 26.09.2017 09:54, Tobias Rapp wrote: >> On 20.09.2017 11:01, Tobias Rapp wrote: >>> Metadata filter output is passed through an Awk script comparing floats >>> against reference values with specified "fuzz" tolerance to account for >>> architectural differences (e.g. x86-32 vs. x86-64). >>> >>> Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> >>> --- >>> tested on Linux x86-32/64 and Mips (Qemu) >>> >>> v4: >>> - fixed iteration order of final print loop >>> - update of debug output >>> >>> v3: >>> - avoid precision loss due to rounding of float values >>> >>> v2: >>> - removed CPUFLAGS work-around for ssim filter issue >>> - added metadata float value post-processing script >>> >>> tests/fate-run.sh | 9 +++++ >>> tests/fate/filter-video.mak | 14 ++++++++ >>> tests/ref/fate/filter-refcmp-psnr-rgb | 45 ++++++++++++++++++++++++ >>> tests/ref/fate/filter-refcmp-psnr-yuv | 45 ++++++++++++++++++++++++ >>> tests/ref/fate/filter-refcmp-ssim-rgb | 30 ++++++++++++++++ >>> tests/ref/fate/filter-refcmp-ssim-yuv | 30 ++++++++++++++++ >>> tests/refcmp-metadata.awk | 64 >>> +++++++++++++++++++++++++++++++++++ >>> 7 files changed, 237 insertions(+) >>> create mode 100644 tests/ref/fate/filter-refcmp-psnr-rgb >>> create mode 100644 tests/ref/fate/filter-refcmp-psnr-yuv >>> create mode 100644 tests/ref/fate/filter-refcmp-ssim-rgb >>> create mode 100644 tests/ref/fate/filter-refcmp-ssim-yuv >>> create mode 100644 tests/refcmp-metadata.awk >>> >>> [...] >> >> I'd like to push this soon, if there are no objections (Nicolas?). > > Unfortunately the patch could not be applied as the reference files > contain trailing whitespace. > > Not sure what would be the preferred way to fix this: > - somehow change the git attributes to treat the reference files as > binary (if possible) > - change the fate test to trim filter output line-by-line > - change the metadata filter itself to trim the affected lines
This last one sounds best. > ? > > Regards, > Tobias > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel