On Wed, Oct 18, 2017 at 10:22:13PM +0200, Michael Niedermayer wrote: > On Wed, Oct 18, 2017 at 12:46:13PM -0700, Michael Bradshaw wrote: > > Thanks for the review! > > > > On Wed, Oct 18, 2017 at 12:26 PM, James Almer <jamr...@gmail.com> wrote: > > > > > > Add a line to Changelog about dropping support for OpenJPEG <= 2.0. > > > > > > > Done. > > > > > +enabled libopenjpeg && require_pkg_config libopenjpeg libopenjp2 > > > openjpeg.h opj_version > > > > > > OpenJPEG 2.0.1 ships a pkg-config file, so change the second argument to > > > "libopenjp2 >= 2.1.0". > > > > > > > Thanks for catching that; I didn't realize 2.0.1 included pkg-config > > support. Fixed. > > > > Aside from that LGTM. It's nice to see all the bloat gone and every > > > future 2.x version being supported without further changes from now on. > > > > > > Yeah, I look forward to the decreased maintenance costs! > > > > Attached is an updated patch with the requested changes to configure and > > Changelog. I plan on pushing this in a few hours (unless, of course, there > > are additional critiques). > > > Changelog | 2 > > configure | 16 ---- > > libavcodec/libopenjpegdec.c | 103 +---------------------------- > > libavcodec/libopenjpegenc.c | 156 > > +++++++------------------------------------- > > 4 files changed, 34 insertions(+), 243 deletions(-) > > e3a7a5c8ebe0d5c0b0eb92c0e61871ab5e9e285e > > 0001-lavc-drop-support-for-OpenJPEG-1.3-2.0.patch > > From fb8334d0cecc889ebce3af968c56a3afbd2f6047 Mon Sep 17 00:00:00 2001 > > From: Michael Bradshaw <mjbs...@google.com> > > Date: Wed, 18 Oct 2017 11:34:06 -0700 > > Subject: [PATCH] lavc: drop support for OpenJPEG 1.3-2.0 > > > > We now require 2.1+ with pkg-config. > > This drops support for all ubuntu versions, there seems to be no > openjpeg above 1.5 in there > > https://packages.ubuntu.com/search?keywords=openjpeg&searchon=names&suite=all§ion=all > from Package openjpeg-tools, the others are spread over multiple package names > trusty (14.04LTS) (graphics): command-line tools using the JPEG 2000 > library [universe] > 1.3+dfsg-4.7ubuntu1: amd64 arm64 armhf i386 powerpc ppc64el > xenial (16.04LTS) (graphics): command-line tools using the JPEG 2000 > library [universe] > 1:1.5.2-3.1: amd64 arm64 armhf i386 powerpc ppc64el s390x > zesty (graphics): command-line tools using the JPEG 2000 library > [universe] > 1:1.5.2-3.1 [ports]: powerpc
correction, xenial and zesty have 2.1.* under the name libopenjp2-7 trusty does not though [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
