2017-10-23 12:31 GMT+02:00 <developm...@axeltechnology.com>: > This patch fixes the MXF format write. This is required for > Sony XDCAM Station and Sony Content Browser compatibility.
The patch contains trailing whitespace and tabs, both cannot be committed to the FFmpeg repository. You can use tools/patcheck to find the issues. > + mxf_write_local_tag(pb, 4, 0x3308); > + if (st->codec->pix_fmt == AV_PIX_FMT_YUV420P) > + avio_wb32(pb, 2); > + else > + avio_wb32(pb, 1); This looks a little suspicious: What does "2" mean, what does "1" mean? (And please consider adding braces around "else", makes future patches in general simpler.) Is there a reason why this patch does not name an author? Thank you, Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel