>The patch contains trailing whitespace and tabs, both cannot be committed to 
>the FFmpeg repository.
>You can use tools/patcheck to find the issues.

Cleaned up the spaces/tabs and added braces around else statemens.


> +    mxf_write_local_tag(pb, 4, 0x3308);
> +    if (st->codec->pix_fmt == AV_PIX_FMT_YUV420P)
> +        avio_wb32(pb, 2);
> +    else
> +        avio_wb32(pb, 1);

>This looks a little suspicious:
>What does "2" mean, what does "1" mean?

Added v_chroma_sub_sample variable instead of '1' and '2' as you suggested.


>Is there a reason why this patch does not name an author?

We are a team of developers and worked together on this patch


>Thank you, Carl Eugen

Thank you for your time
Axel Technology development team


Attachment: 0001-Sony-XDCAM-Fix.patch
Description: Binary data

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to