On 25.10.2017 20:01, Michael Niedermayer wrote:
On Wed, Oct 25, 2017 at 07:55:52PM +0200, Michael Niedermayer wrote:
On Tue, Oct 24, 2017 at 11:47:21AM +0200, Tobias Rapp wrote:
According to EBU tech 3285 supplement 3 the dwPosPeakOfPeaks field
should contain the absolute position to the maximum audio sample value,
but the current implementation writes the relative peak frame index
instead.
Fix the issue by writing the "unknown" value (-1) for now until the
feature is implemented correctly.
Previous version reviewed-by: Peter Bubestinger <p.bubestin...@av-rd.com>
Signed-off-by: Tobias Rapp <t.r...@noa-archive.com>
---
v2:
- added version micro bump
- more code clean-up
libavformat/version.h | 2 +-
libavformat/wavenc.c | 11 +----------
tests/ref/lavf/wav_peak | 2 +-
tests/ref/lavf/wav_peak_only | 2 +-
4 files changed, 4 insertions(+), 13 deletions(-)
will apply, thanks
rather LGTM, feel free to apply
Applied, thanks for review.
Regards,
Tobias
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
