On Thu, Nov 16, 2017 at 12:14:30PM -0500, Dave Rice wrote: > > > On Nov 16, 2017, at 11:30 AM, Dave Rice <d...@dericed.com> wrote: > > > >> On Jul 9, 2017, at 7:26 PM, Dave Rice <d...@dericed.com> wrote: > >> > >>> On Jul 7, 2017, at 7:06 PM, Derek Buitenhuis <derek.buitenh...@gmail.com> > >>> wrote: > >>> > >>> On 7/7/2017 10:13 PM, James Almer wrote: > >>>> Isn't this necessary only for files with raw video? As is, this box > >>>> would be written on any mov file with a video stream. > >>> > >>> This was addressed a previous email: > >>> > >>> http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2017-July/213350.html > >>> > >>> I guess the spec is up for interpretation. > >> > >> The quicktime spec says "This is a mandatory extension for all > >> uncompressed Y´CbCr data formats”. It doesn’t clarify if the clap atom is > >> recommended or not in mov files that are not “uncompressed Y´CbCr”, though > >> it would make sense if the video container needs to store cropping data. I > >> think constraining the change for only “uncompressed Y´CbCr” would be > >> more cautious though. I’ll revise my patch to include the condition and > >> resubmit. > >> > >> If the patch only impacts “uncompressed Y´CbCr” would any fate updates be > >> needed? > >> Dave Rice > > > > Here’s an update to only write the clap atom for the specific uncompressed > > encodings listed in TN2162. > > > > From 37457c1ee135f39452b91b047af4adf1ec43464b Mon Sep 17 00:00:00 2001 > > From: Dave Rice <d...@dericed.com> > > Date: Thu, 16 Nov 2017 11:29:06 -0500 > > Subject: [PATCH] avformat/movenc: write clap atom for uncompressed yuv in > > mov > > Sorry, this patch should supersede the prior email's patch. I realized that > Apple requires new uncompressed ycbcr files to use version 2 in the Image > Description, so I reused the uncompressed_ycbcr variable to add that in as > well. > > From 3ea99e7d22f67b8a556152acbcbc8bf2eeec8a39 Mon Sep 17 00:00:00 2001 > From: Dave Rice <d...@dericed.com> > Date: Thu, 16 Nov 2017 11:29:06 -0500 > Subject: [PATCH 1/2] avformat/movenc: write clap atom for uncompressed yuv in > mov > > fixes 6145 > --- > libavformat/movenc.c | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-)
please add a fate test and if this is tested with some official player and works then LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User questions about the command line tools should be sent to the ffmpeg-user ML. And questions about how to use libav* should be sent to the libav-user ML.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
