2017-12-15 16:21 GMT+08:00 Jeyapal, Karthick <kjeya...@akamai.com>: > > >>On 12/15/17, 4:45 AM, "Liu Steven" <l...@chinaffmpeg.org> wrote: >> >> >>> 在 2017年12月15日,上午6:28,Liu Steven <l...@chinaffmpeg.org> 写道: >>> >>>> >>>> 在 2017年12月15日,上午12:29,Jeyapal, Karthick <kjeya...@akamai.com> 写道: >>>> >>>>> On 12/14/17, 8:24 PM, "Steven Liu" <l...@chinaffmpeg.org> wrote: >>>>> >>>>> >>>>>> 在 2017年12月14日,下午6:55,vdi...@akamai.com 写道: >>>>>> […] >>>>>> +libavformat/reverse.c >>>>> >>>>> this need double check for a better way >>>> The better way of doing this is to share ff_reverse function. >>> No I don’t think that is a better way here. >>>> But such a patch submitted recently was not pushed due to several >>>> objections. >>>> http://ffmpeg.org/pipermail/ffmpeg-devel/2017-December/221472.html >>>> Hence, we are left with only this option. Moreover like same approach was >>>> used for avcodec and avdevice(to add reverse.c), as well. So, extending >>>> the same approach for avformat shouldn’t deviate from ffmpeg’s principles. >>> I think there have better way, Please don’t define the ffmpeg’s principles >>> to every place. you are duplicate the code from libavcodec//reverse.c to >>> libavformat, IMHO, that is not a good option. >>I need some time to think about that. > Oh sure. Thanks. > In that case, could you please merge PATCH v6 1/3 alone, since that is a > relatively independent feature.
patch -p1 < ~/Downloads/FFmpeg-devel-v6-1-3-avformat-hlsenc-addition-of-EXT-X-MEDIA-tag-and-AUDIO-attribute.patch cd xxx/ rm -rf * ../configure --disable-network --disable-everything --enable-muxer=hls make CC libavformat/hlsenc.o src/libavformat/hlsenc.c:1142:21: error: use of undeclared identifier 'master_pb' avio_printf(master_pb, "#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID=\"group_%s\"", ^ src/libavformat/hlsenc.c:1144:21: error: use of undeclared identifier 'master_pb' avio_printf(master_pb, ",NAME=\"audio_0\",DEFAULT=YES,URI=\"%s\"\n", ^ 2 errors generated. make: *** [libavformat/hlsenc.o] Error 1 make: *** Waiting for unfinished jobs.... _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel