On Wed, Feb 14, 2018 at 09:48:20AM +0100, Jerome Martinez wrote: > Add support for 10- and 12-bit/component RGB with Alpha encoding and > decoding in FFV1. > > Benched with START/STOP_TIMER around "for (x = 0; x < w; x++)" part during > decoding, before the previous patch and with the previous patch + this > patch, no obvious impact (+/-1%), e.g. with 1 second of gbrp12 4K content: > ffmpeg -i a.mkv -f framemd5 a.framemd5 -y > 325549 UNITS in decode_rgb_frame, 130899 runs, 173 skips > frame= 24 fps=1.3 q=-0.0 Lsize= 2kB time=00:00:01.00 bitrate= > 17.1kbits/s speed=0.0544x > > The 2 deleted lines are the ones I inadvertently kept after testing in my > previous patch, they are actually never used. > > Some input test files used for testing (input file framemd5 = FFV1 file > framemd5): > https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket2392/converted_image_gets_skewed.dpx > https://samples.ffmpeg.org/image-samples/dpx_samples.zip > > For reference, this leads to the following array of supported pix_fmt > (underscore means not supported): > Y : 8/_/10/12/__/16 > YA : 8/_/__/__/__/__ > YUV 420: 8/9/10/12/__/16 > YUVA 420: 8/9/10/__/__/16 > YUV 422: 8/9/10/12/__/16 > YUVA 422: 8/9/10/__/__/16 > YUV 444: 8/9/10/12/__/16 > YUVA 444: 8/9/10/__/__/16 > RGB : 8/9/10/12/14/16 > RGBA : 8/_/10/12/__/16 > and 8-bit for YUV 410/411/440 > it could be interesting for coherency in the listed supported pix_fmt to > fill some gaps when corresponding pix_fmt exists in FFmpeg e.g. YUVA 12-bit, > GRAY9 or YA16 >
> ffv1dec.c | 4 ++++ > ffv1dec_template.c | 4 +--- > ffv1enc.c | 3 +++ > ffv1enc_template.c | 2 +- > 4 files changed, 9 insertions(+), 4 deletions(-) > 156fd44f16601376ba5d5dcc9f8ab935b6f83726 > 0001-avcodec-ffv1-Support-for-GBRAP10-and-GBRAP12.patch > From 3d24b30f2f23a2624e00333911e82fb48cf6d35c Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jer...@mediaarea.net> > Date: Wed, 14 Feb 2018 08:39:15 +0100 > Subject: [PATCH] avcodec/ffv1: Support for GBRAP10 and GBRAP12 will apply please add fate tests thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
