On 27 February 2018 at 23:56, Aurelien Jacobs <au...@gnuage.org> wrote:
> > So I've updated the patch with only a msbc and a delay option and > I've added some sane parameters decisions, mainly based on the following > study : > https://pdfs.semanticscholar.org/1f19/561d03bc88b67728375566c95bbf77 > e730d5.pdf > This seems to give pretty good results. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > I think you ought to use a float for this, like: >{ "sbc_delay", "Maximum delay in milliseconds", offsetof(<context>, <option>), AV_OPT_TYPE_FLOAT, { .dbl = <some reasonable default> }, <min>, <max>, <flags>, <option name in structure> }, Apart from that, what's up with the weird if (!sbc->init) { } block in the main encoding function? Shouldn't that be done in sbc_encode_init()? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
