On Wed, Mar 28, 2018 at 09:35:12PM +0300, Jan Ekström wrote: > On Wed, Mar 28, 2018 at 9:12 PM, Michael Niedermayer > <mich...@niedermayer.cc> wrote: > >> + /** > >> + * An in-order array of entries for the given timeline. > >> + * Each entry contains information on which samples to display for a > >> + * particular edit. > >> + */ > >> + AVTimelineEntry *entries; > > > > This is problematic as its non extensible. (unless iam missing something) > > Consider that a field is added to AVTimelineEntry, the entries array would > > have a larger element size and that would require all user apps to be > > rebuild > > > > So you would prefer some sort of iterator? Or a size entry like with > some of the entries in AVEncryptionInfo? I have a feeling this was > based off of the following added into AVEncryptionInfo: > + AVSubsampleEncryptionInfo *subsamples; > + uint32_t subsample_count; > > Which now would seem to be similarly not being extendable? > > > Also, if you want to support quicktime more fully theres more needed. > > QT can for example switch even between codecs mid stream IIRC > > not sure we want to support this > > > > Thankfully, that has little to do with virtual timelines (edit lists) > as far as I can tell?
Well, no unless we want a single unified API that represents information about timespans. We can use completely unrelated systems to handle the virtual timeline, the codec and related changes, chapters, ... [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel