On Thu, Mar 29, 2018 at 03:58:09PM -0700, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva <is...@isasi.mtv.corp.google.com>
> ---
>  libavformat/mov.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

The commit message should explain why this change is done.
Not just what is changed


[...]

> @@ -3594,7 +3595,7 @@ static void mov_fix_index(MOVContext *mov, AVStream *st)
>                      edit_list_start_encountered = 1;
>                      // Make timestamps strictly monotonically increasing for 
> audio, by rewriting timestamps for
>                      // discarded packets.
> -                    if (st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO && 
> frame_duration_buffer) {
> +                    if (frame_duration_buffer) {

The comment above needs an update too i think

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein

Attachment: signature.asc
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to