On Wed, 11 Apr 2018 14:25:15 +0100
Rostislav Pehlivanov <atomnu...@gmail.com> wrote:

> On 11 April 2018 at 06:22, Timo Teräs <timo.te...@iki.fi> wrote:
> 
> > Ping.
> >
> > Any comments on this?
> >
> > There was also recently the flacenc support for cover images, and
> > the question if some of this code should be moved to generic code
> > in mux.c so both can share it: e.g. storing the image packets to
> > attached_pic - or if that should be moved to the muxer private
> > structs.
>
> I think this could be done at a later stage as well, but if you or
> jamrial think it can be reused, sure, go ahead and submit a separate
> patch which puts it in some common code.

I agree that it might be easier done later. This way we get the commits
in with proper authors and have common code base to work on. Producing
a suitable framework interface might need additional discussions too.

Would there be other concerns or comments for my patch then, or could
it be considered to be committed?

Thanks
timo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to