On Fri, Apr 27, 2018 at 02:06:04PM -0700, Rahul Chaudhry wrote: > It was reported on github that this patch causes build errors with xcode: > > https://github.com/FFmpeg/FFmpeg/commit/b22db4f465c9adb2cf1489e04f7b65ef6bb55b8b#commitcomment-28725295 > > The attached patch fixes the build errors by renaming the labels. This time > I've tested it with clang from xcode on a MacBook to verify that the build > works. > > Thanks, > Rahul > > > On Thu, Apr 19, 2018 at 11:06 AM, Michael Niedermayer > <mich...@niedermayer.cc> wrote: > > On Wed, Apr 18, 2018 at 04:40:28PM -0700, Rahul Chaudhry wrote: > >> On Wed, Apr 18, 2018 at 3:46 PM, Michael Niedermayer > >> <mich...@niedermayer.cc> wrote: > >> > please make sure this works on apple based arm (unless you know it works) > >> > (ive tested qemu linux based) > >> > > >> > Also please add a commit message > >> > >> If by 'apple based arm' you mean llvm/clang assembler, then yes, I've > >> verified > >> that the assembly works with armv7a-cros-linux-gnueabi-clang (version > >> 7.0.0). > >> > >> Updated patch with new commit message is attached. > >> > >> Thanks, > >> Rahul > > > >> From 2e3318acf266b519e98b680102a07196d6ddbf93 Mon Sep 17 00:00:00 2001 > >> From: Rahul Chaudhry <rahulchaud...@chromium.org> > >> Date: Wed, 18 Apr 2018 16:29:39 -0700 > >> Subject: [PATCH] swresample/arm: remove unintentional relocation. > > > > ok, will apply > > > > thx
> From a58b726947cc22081d899894036fa01933dfac0a Mon Sep 17 00:00:00 2001 > From: Rahul Chaudhry <rahulchaud...@chromium.org> > Date: Fri, 27 Apr 2018 13:49:52 -0700 > Subject: [PATCH] swresample/arm: rename labels to fix xcode build error will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel