On Mon, Jun 04, 2018 at 05:36:19PM +0300, Timo Teräs wrote: > For chapter images, the mov demux produces streams with disposition set > to attached_pic+timed_thumbnails. This patch fixes to properly recognize > streams that should be encoded as cover image (ones with only and only > attached_pic disposition set). > > Signed-off-by: Timo Teräs <timo.te...@iki.fi> > --- > > ffmpeg should act close to what a inteligent user expects. > > For example a simple ffmpeg -i inputfile outputfile > > should produce a outputfile that results in similar presentation as the > > input > > when played. > >... > > It may be good to minimize the amount of exceptions for how streams are > > handled. > > Agree. My question was more about the details how the disposition flags > should be handled, because there seems to be no accurate documentation. > Apparently the logic is to handle based on what demuxers produce. > > This patch addresses how the cover image is detected, and should restore > earlier behaviour on copying files where demuxer supports more features > than current muxer. > > This applies on top of the "[v2] avformat/movenc: properly handle cover > image codecs" patch. I can rebase the order if wanted, but it'll require > little work. > > Hopefully just the above mentioned patch, and this one could be applied > in the order.
will apply the 2 patches adding a fate test may make sense, the patches didnt change any so its not tested thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel