Thanks for letting me know about this. I actually submitted another patch without long commit message. I will clean up according to your feedback after getting feedbacks from other people.
On Sat, Jun 16, 2018 at 2:52 AM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Thu, Jun 14, 2018 at 08:35:48PM +0800, Wang Cao wrote: > > Signed-off-by: Wang Cao <wang...@google.com> > > --- > > fftools/ffmpeg.c | 45 +++++++++++++++++++++++++++++++-------------- > > 1 file changed, 31 insertions(+), 14 deletions(-) > > this adds some warnings: > > CC fftools/ffmpeg.o > fftools/ffmpeg.c:1533:13: warning: function declaration isn’t a prototype > [-Wstrict-prototypes] > static void print_final_stats() > ^ > fftools/ffmpeg.c: In function ‘print_report’: > fftools/ffmpeg.c:1672:22: warning: unused variable ‘oc’ [-Wunused-variable] > AVFormatContext *oc; > ^ > > also the commit message should not be one very long line > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > What does censorship reveal? It reveals fear. -- Julian Assange > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Wang Cao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
