On 20/06/18 02:33, Danil Iashchenko wrote: > lavfi: Add boxblur_opencl filter. Behaves like existing boxblur filter. > --- > > Thanks, fixed. > > configure | 1 + > libavfilter/Makefile | 6 +- > libavfilter/allfilters.c | 1 + > libavfilter/boxblur.c | 107 +++++++++++++++ > libavfilter/boxblur.h | 68 ++++++++++ > libavfilter/vf_avgblur_opencl.c | 283 > ++++++++++++++++++++++++++-------------- > libavfilter/vf_boxblur.c | 116 ++-------------- > 7 files changed, 373 insertions(+), 209 deletions(-) > create mode 100644 libavfilter/boxblur.c > create mode 100644 libavfilter/boxblur.h
LGTM; one minor but critical thing left: > ... > diff --git a/libavfilter/boxblur.h b/libavfilter/boxblur.h > new file mode 100644 > index 0000000..9e4e818 > --- /dev/null > +++ b/libavfilter/boxblur.h > @@ -0,0 +1,68 @@ > +/* > + * Copyright (c) 2002 Michael Niedermayer <michae...@gmx.at> > + * Copyright (c) 2011 Stefano Sabatini > + * Copyright (c) 2018 Danil Iashchenko > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with FFmpeg; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 > USA > + */ > + > +#ifndef BOXBLUR_H > +#define BOXBLUR_H > + > ... > + > +#endif // BOXBLUR_H These include guards fail part of the fate-source check - they should match the name of the file (AVFILTER_BOXBLUR_H). I fixed this myself, and applied. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel