> > I believe users will expect that "size" shows the file size, especially > since this was done for more than a decade.
If this is the convention, I believe it should be kept as it was. On the other hand, I believe "bitrate" should be calculated through stream size not the file size. On Thu, Jul 12, 2018 at 2:18 PM Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-07-12 20:56 GMT+02:00, Wang Cao <doublee...@gmail.com>: > > > After my change: > > > >> frame= 3 fps=0.0 q=2.0 Lsize= 51kB time=00:00:00.12 > >> bitrate=3495.7kbits/s speed= 12x > > > > Before my change(master branch) > > > >> frame= 3 fps=0.0 q=2.0 Lsize= 57kB time=00:00:00.12 > >> bitrate=3884.7kbits/s speed=11.2x > > > > The size is different (51 vs 57) because I display the stream > > size instead of the total file size. I think stream size > > is more suitable in this context with "frame, fps, time". > > For bitrate, I use the stream size to calculate it and I think > > it's more accurate. > > I believe users will expect that "size" shows the file size, especially > since this was done for more than a decade. > > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Wang Cao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel