On 10/10/18, Marc-Antoine ARNAUD <arnaud.marcanto...@gmail.com> wrote: > For me it's the only codec who use picture colorspace as source. > All others uses only the CodecContext. > I don't know the exact reason, but I suppose it can be easiest to manage > output colorspace during merge of video, as a video can have only one > "static" video colorspace. > > So for me it made sense to keep that patch. Maybe with removing the `else` > to don't take colorspace from pictures as other codecs can do.
That seems reasonable. What other people think? > > Marc-Antoine > > Le ven. 5 oct. 2018 `a 10:15, Paul B Mahol <one...@gmail.com> a ecrit : > >> On 10/5/18, Marc-Antoine ARNAUD <arnaud.marcanto...@gmail.com> wrote: >> > In our case we have some files with bad colorspaces (in HD but with >> > bt601 >> > colorspace). >> > So we use -colorspace, -color_trc, -color_primaries to force the output >> > colorspace. >> > >> > We keep compatibility with "old command line", we get source colorspace >> if >> > nothing is mentionned. >> > It work like that for Mpeg2video codec, so we expect to have the same >> here. >> >> Correct patch should be one that changes frame properties, otherwise >> every encoder that uses these properties needs to be updated with extra >> lines to maintain. >> >> > >> > Marc-Antoine >> > >> > >> > Le jeu. 4 oct. 2018 `a 18:36, Paul B Mahol <one...@gmail.com> a ecrit : >> > >> >> On 10/4/18, Marc-Antoine ARNAUD <arnaud.marcanto...@gmail.com> wrote: >> >> > >> >> > >> >> >> >> Why? >> >> >> >> IIRC this patch is not needed. >> >> _______________________________________________ >> >> ffmpeg-devel mailing list >> >> ffmpeg-devel@ffmpeg.org >> >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> >> > _______________________________________________ >> > ffmpeg-devel mailing list >> > ffmpeg-devel@ffmpeg.org >> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > > > -- > *Marc-Antoine* > |e:arnaud.marcanto...@gmail.com > |tel: 06-84-71-84-45 > | ohloh: http://bit.ly/1iwtlsU > [image: LinkedIn] > <http://s.wisestamp.com/links?url=https%3A%2F%2Fwww.linkedin.com%2Fpub%2Fmarc-antoine-arnaud%2Fb%2F7b8%2F2a3&sn=YXJuYXVkLm1hcmNhbnRvaW5lQGdtYWlsLmNvbQ%3D%3D> > [image: > Google Plus] > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel