On 12/6/18, Baptiste Coudurier <baptiste.coudur...@gmail.com> wrote: > On Thu, Dec 6, 2018 at 7:45 AM Paul B Mahol <one...@gmail.com> wrote: > >> On 12/6/18, Baptiste Coudurier <baptiste.coudur...@gmail.com> wrote: >> > Hi Paul, >> > >> > On Wed, Dec 5, 2018 at 3:18 PM Paul B Mahol <one...@gmail.com> wrote: >> > >> >> On 12/6/18, Baptiste Coudurier <baptiste.coudur...@gmail.com> wrote: >> >> > Hi Paul >> >> > >> >> > On Wed, Dec 5, 2018 at 9:52 AM Paul B Mahol <one...@gmail.com> wrote: >> >> > >> >> >> Signed-off-by: Paul B Mahol <one...@gmail.com> >> >> >> --- >> >> >> libavformat/mxfenc.c | 49 >> ++++++++++++++++++++++++++++++++++++++++++++ >> >> >> 1 file changed, 49 insertions(+) >> >> >> >> >> >> [...] >> >> >> >> >> >> +static int mxf_parse_prores_frame(AVFormatContext *s, AVStream *st, >> >> >> AVPacket *pkt) >> >> >> +{ >> >> >> + MXFContext *mxf = s->priv_data; >> >> >> + MXFStreamContext *sc = st->priv_data; >> >> >> + int i, profile; >> >> >> + >> >> >> + if (mxf->header_written) >> >> >> + return 1; >> >> >> + >> >> >> + sc->codec_ul = NULL; >> >> >> + profile = st->codecpar->profile; >> >> >> >> >> > >> >> > We should fetch the profile from the bitstream. >> >> > >> >> >> >> AFAIK profile is not stored in it. >> >> >> > >> > Right. My thinking is how would this work going from MOV to MXF ? Or >> would >> > it work when encoding ? >> >> It works when encoding and stream copying, last time I tried. >> > > After looking at the code, it seems like it would work assuming essence > comes from MXF or MOV, > raw would not work though but we can accept that. > > So I think the patch is fine, as well as the demuxer one, could you please > apply the demuxer one first ?
It is listed before muxer anyway, muxer patch is last one. Or there is something I'm missing. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel