Uwe Freese (2018-12-26): > Parts of the previous code are now in an "if" statement block (function > apply_delogo), so indentation is correct. Even it would maybe be better to > read the diff, it wouldn't be correctly indented. > > In the parameter lists, spaces are added to have the same layout of the > descriptions in the right part for all lines. > > So what should I do in this case? > > I could create a diff of course with "wrong" indentation (not correctly > indented and not good to read in the final file, but the diff is better to > read...). Would this help for the first review?
The practice in FFmpeg for this kind of situation is to first make a commit without re-indenting (hence having the "wrong" indentation) and then make a second commit with only the re-indent. Since working on the real patch while juggling with the indentation commit can be annoying, you can wait until the patch is in its final form to even bother about the re-indent. You can flag the places where it is needed with /* TODO reindent */ if you find it useful. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
