> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Thursday, December 27, 2018 9:06 PM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V2] avfilter: Add tonemap vaapi filter > > On Thu, Dec 27, 2018 at 04:55:17PM +0800, Zachary Zhou wrote: > > It supports ICL platform. > > H2H (HDR to HDR): P010 -> RGB10 > > H2S (HDR to SDR): P010 -> RGB8 > > > > libva commit for HDR10 > > > https://github.com/intel/libva/commit/cf11abe5e1b9c93ee75cf974076957162 > c1605b9 > > > > Signed-off-by: Zachary Zhou <zachary.z...@intel.com> > > --- > > configure | 2 + > > libavfilter/Makefile | 1 + > > libavfilter/allfilters.c | 1 + > > libavfilter/vaapi_vpp.c | 29 ++ > > libavfilter/vaapi_vpp.h | 8 + > > libavfilter/vf_tonemap_vaapi.c | 542 > +++++++++++++++++++++++++++++++++ > > libavutil/hwcontext_vaapi.c | 1 + > > 7 files changed, 584 insertions(+) > > create mode 100644 libavfilter/vf_tonemap_vaapi.c > > breaks build > CC libavutil/hwcontext_vaapi.o > src/libavutil/hwcontext_vaapi.c:127:19: error: use of undeclared identifier > 'VA_RT_FORMAT_RGB32_10' > { 0x41424752, VA_RT_FORMAT_RGB32_10, AV_PIX_FMT_GBRP10LE, 0, }, > ^ > src/libavutil/hwcontext_vaapi.c:143:28: error: invalid application of > 'sizeof' to > an incomplete type 'const VAAPIFormatDescriptor []' > for (i = 0; i < (sizeof(vaapi_format_map) / > sizeof((vaapi_format_map)[0])); > i++) > ^~~~~~~~~~~~~~~~~~ > src/libavutil/hwcontext_vaapi.c:153:28: error: invalid application of > 'sizeof' to > an incomplete type 'const VAAPIFormatDescriptor []' > for (i = 0; i < (sizeof(vaapi_format_map) / > sizeof((vaapi_format_map)[0])); > i++) > ^~~~~~~~~~~~~~~~~~ > 3 errors generated. > make: *** [libavutil/hwcontext_vaapi.o] Error 1 > make: Target `all' not remade because of errors. >
Thanks Michael for the check, I am fixing the issue with - +#ifdef VA_RT_FORMAT_RGB32_10 MAP(RGBA, RGB32_10, GBRP10, 0), +#endif I will resend the patch soon. -Zach > > > [...] > -- > Michael GnuPG fingerprint: > 9FF2128B147EF6730BADF133611EC787040B0FAB > > Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel