On Mon, 21 Jan 2019, Nicolas George wrote:

Marton Balint (12019-01-04):
Agreed, and this is how it should work even after the patch. user_duration
which is the duration specified in the ffconcat file always have priority
because get_best_effort_duration always considers that first. So it does not
matter that we assign ConcatFile->duration again and again, because we will
just reassing the same value.

Given that, I don't think an inconsitent state is possible because seeking
is only allowed if the durations are known (if they are all set in the
ffconcat file). On the other hand, if generic seeking is not allowed, then
start_time will never be invalid because we always recalculate it for the
next file when we open it.

Does this relax your concern?

I think it does. Sorry for forgetting to reply to this. Please go ahead
when convenient.

Thanks, pushed the remaining parts of the series.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to