On Thu, Feb 21, 2019 at 01:16:00PM +0200, Jan Ekström wrote: > This fixes buffering of samples which causes sudden ballooning of > memory usage in case of no subtitle samples coming in for a while if > the filter chain had been re-initialized. > > You can also see messages a la: > "Error while add the frame to buffer source(Invalid argument)." > disappearing after filter chain re-initializations. > > Passes fate-sub2video. > > Example (memory usage before patch around 700+ MiB, after around 150MiB) : > /usr/bin/time -v ffmpeg -v verbose \ > -i > "https://megumin.fushizen.eu/samples/2019-01-18-audio_reconfig_causes_buffer_growth.ts"; > \ > -filter_complex > '[0:v:0]yadif=deint=interlaced[yadif_out];[yadif_out][0:s:0]overlay=eof_action=pass:repeatlast=0[overlay_out];[overlay_out]scale=1024:-2[video_out];[0:a:0]aresample=48000:async=1,aformat=channel_layouts=stereo[filtered_audio]' > \ > -map "[video_out]" \ > -c:v mpeg4 \ > -b:v 750k \ > -map "[filtered_audio]" \ > -c:a aac \ > -b:a 192k \ > "test.mp4" > > Best regards, > Jan
> ffmpeg_filter.c | 1 + > 1 file changed, 1 insertion(+) > 5f88558fef759023173b4c8efe157aa30fc9e337 > 0001-ffmpeg_filter-initialize-sub2video.end_pts-together-.patch > From 9c824c36c972aca19f2747437c8edc71b6c0886c Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= <jee...@gmail.com> > Date: Thu, 20 Feb 2019 20:54:11 +0200 > Subject: [PATCH] ffmpeg_filter: initialize sub2video.end_pts together with > last_pts Breaks: (video stream is empty after this) when a duration is used ./ffmpeg -i in.mkv -filter_complex '[0:s:1]scale=800:600' -t 15 -qscale 2 test.avi both video and subtitles appear in the first 5 seconds input is a pgs in mkv file. If you cannot reproduce with a random file then say so and ill try to turn the file i have into a small testcase i can share thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
