On 3/17/19, Nick Renieris <velocit...@gmail.com> wrote: > Στις Κυρ, 17 Μαρ 2019 στις 10:43 π.μ., ο/η Paul B Mahol > <one...@gmail.com> έγραψε: >> Are you sure that this does not break support with previously supported >> files. >> Please remove return statement. > > By "support" you mean the thumbnail thing? Did you read the > StackExchange question? I would consider it more of a bug than > support... > I can't imagine any user wanting to convert their DNG files that would > actually want FFmpeg to use the low quality images that are normally > used for thumbnails.
Please try with option adding instead(-subimage). It will ignore thumbnail and try to decode rest of image. Anyhow the return statement is invalid, as it breaks support for files that are already working just fine. > > Στις Κυρ, 17 Μαρ 2019 στις 10:56 π.μ., ο/η Carl Eugen Hoyos > <ceffm...@gmail.com> έγραψε: >> >> Am So., 17. März 2019 um 08:46 Uhr schrieb <velocit...@gmail.com>: >> >> > - case TIFF_WHITE_LEVEL: >> > + case DNG_WHITE_LEVEL: >> >> Why is this a good change? > > Because I added a DngTags enum and this WhiteLevel tag is specified in > the DNG spec. If I removed it I would also have to name the two added > and all future DNG tags as TIFF_*, which I think is worse than having > a separate enum (since DNG images are quite different than TIFFs). > >> I don't think above change (to error out for dng) justifies this >> change. > > True, I didn't consider that. Will remove. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel