> From: avih [mailto:avih...@yahoo.com] > Sent: Wednesday, April 24, 2019 9:23 PM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Cc: Guo, Yejun <yejun....@intel.com> > Subject: Re: [FFmpeg-devel] [PATCH V5 2/2] configure: replace 'pr' with printf > since busybox does not support pr > > > log_file(){ > > - log BEGIN $1 > > - pr -n -t $1 >> $logfile > > - log END $1 > > + log BEGIN "$1" > > + log_file_i=1 > > + while IFS= read -r log_file_line;do > > + printf '%5s %s\n' "${log_file_i}" "${log_file_line}" > > + log_file_i=$(($log_file_i+1)) > > + done < "$1" >> "$logfile" > > + log END "$1" > > } > > Looks good to me, no further comments (but I don't push).
this patch set asks for push, or more comments, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".