> -----Original Message----- > From: Pedro Arthur [mailto:bygran...@gmail.com] > Sent: Tuesday, April 30, 2019 1:47 AM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Cc: Guo, Yejun <yejun....@intel.com> > Subject: Re: [FFmpeg-devel] [PATCH V2 7/7] libavfilter/dnn: add more data type > support for dnn model input > > + sr_context->input.dt = DNN_FLOAT; > > sr_context->sws_contexts[0] = NULL; > > sr_context->sws_contexts[1] = NULL; > > sr_context->sws_contexts[2] = NULL; > > -- > > 2.7.4 > > > > LGTM. > > I think it would be valuable to add a few tests covering the features > added by this patch series.
I tried a bit to add FATE for dnn module, see basic code in attached file. We can only test native mode because FATE does not allow external dependency. The native mode is still in early stage, and I plan to add support to import TF model as native model with ffmpeg c code (as discussed in another thread). That's might be a better time to add FATE after the import is finished. We can add unit tests for all the native ops at that time. As for this patch series, it mainly focus on the TF mode, it might not be suitable to add FATE for it. So, how about to push this patch set, and add FATE when the native mode is a little more mature? thanks. > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
0001-add-a-unit-test-for-dnn-module.patch
Description: 0001-add-a-unit-test-for-dnn-module.patch
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
