Thank you for your suggestions. I will push an update to the patch with documentation and will hold off on STT and EIT[0-3] tables for a later patch.
On Mon, May 20, 2019 at 7:24 AM Devin Heitmueller < dheitmuel...@kernellabs.com> wrote: > On Mon, May 20, 2019 at 8:36 AM Phil Burr <phil.b...@gmail.com> wrote: > > > > Thank you for the feedback. I will look into adding documentation for > the > > atsc metadata. ATSC requires in addition to the tables I've added, the > STT > > and EIT0-EIT3 tables. I'm thinking of adding support for STT and at > least > > producing empty EIT tables so that the stream would be minimally > compliant. > > I would have no problem with them being excluded in a first version of > the patch, as long as it's documented that they are not expected to be > present in the resulting streams. > > Your patch is already a huge improvement over the current state of > affairs, and I don't want to see your patch not get merged because it > lacks two features that I think the vast majority of people won't care > about. > > Devin > > -- > Devin J. Heitmueller - Kernel Labs > http://www.kernellabs.com > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".