On Mon, Jun 24, 2019 at 09:18:13PM +0530, Shivam wrote: > Hi! > > The code is to add DICOM Support. The patch is only for uncompressed > dicom files using explicit value representation. I would extend it, once i > clarify some doubts. As dicom image files contain lots of metadata about > the patient. So, should i display that data while demuxing or should i > ignore and only demux the image data ?. In the current patch, i have made an > option "-metadata", which when used will print the data on the terminal > while demuxing.
metadata should be exported to be usable by applications. For teh API design a one test is that it should be possible to have a dicom file as input and a format with similar features as output and not loose any significant data. Printing to the terminal cannot achieve that easily. Either way i would suggest to support only a subset of these 4000 elements for now but try to ensure that the deisgn can handle most of the important elements > > > Also, in the dicomdict.c ( which is only required for implicit dicom files, > and for metadata), till now i have only specified ~200 data elements. but > the dicom specification, specifies a total of ~4000 data elements (would do > binary search if all the tags are needed ). So, is there a better way to > specifiy that data?. (I mean if we ignore the metadata about the patient, > then we only need to specify ~150 data elements for image data). > > > I have uploaded some samples of dicom files with explicit value > representation here (in case needed). > > https://drive.google.com/drive/folders/1V8HUNeX3EYiPLj_dcFt8C68tAh7C7v4X?usp=sharing > > > Please comment, breaks fate tests make: *** [fate-codec_desc] Error 1 make: *** [fate-source] Error 1 Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a program halts or runs forever is On a turing machine, in general impossible (turings halting problem). On any real computer, always possible as a real computer has a finite number of states N, and will either halt in less than N cycles or never halt.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".