On Thu, Jun 27, 2019 at 09:40:22AM +0200, Moritz Barsnick wrote: > On Thu, Jun 27, 2019 at 10:12:35 +0800, lance.lmw...@gmail.com wrote: > > +This filter takes in two video input, the first input is considered > ^ inputs > > +the "main" source and is passed unchanged to the output. The "second" > > +input is used as a rectangular object for finding, now the "second" > ^^^^^ Now? > The part from "now" - once you have clarified why the word "now" > belongs here - should be a separate sentence.
Please help to check my updated words for the v3 patch > > -ffmpeg -i file.ts -vf find_rect=newref.pgm,cover_rect=cover.jpg:mode=cover > > new.mkv > > +ffmpeg -i file.ts -newref.pgm -filter_complex > > find_rect,cover_rect=cover.jpg:mode=cover new.mkv > ^^^^ This is certainly wrong. > > > -ffmpeg -i file.ts -vf find_rect=newref.pgm,cover_rect=cover.jpg:mode=cover > > new.mkv > > +ffmpeg -i file.ts -newref.pgm -filter_complex > > find_rect,cover_rect=cover.jpg:mode=cover new.mkv > ^^^^ ditto > Yes, it's typo, fixed. > If you change the options behavior of a filter, you should bump > libavfilter micro version. Fixed. > > I can't just on most of the rest of your changes. > > Moritz > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".