Hi Paul, > > I disagree. Based on your code the 4 modes do this: > > < -1 = 0 > > -1 = WRITE_HEADER > > 0 = WRITE_HEADER | ONE_PACKET_ONLY > > > > > 0 = ONE_PACKET_ONLY > > > > You documented the meaning of the "modes" in two places and created two > > helper functions to make sure you pass the correct modes to the underlying > > function. Why is that if not because you can't seem to remember yourself > > the meaning of modes? Please reconsider using defines or enums. > > Hardcoded values are unacceptable. Every such patch will not be applied > and if someone applies it by accident it will be reverted ASAP.
The code doesn't use any hardcoded value! What Marton is commenting here it's a mistake of him. The variable "write_mode" inside the function "write_side_streams()" of the patch is a COUNTER. He thought it had something to do with a comment on the parameter "mode" in the function "mpegts_write_pes()". But is false. In any case, I'll change the value of the parameter "mode" in "mpegts_write_pes()". Please, note that a new version of the patch is ready published: https://patchwork.ffmpeg.org/patch/13745/ Regards. A.H. --- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
