> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Eoff, Ullysses A > Sent: Saturday, July 13, 2019 12:26 > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: use -reinit_filter > to disable/enable auto scale > > > > > Add an option to disable/enable "auto insert" is Ok for me, but I > > > > think if you reuse the -reinit_filter option, you need to update doc > > > > part at the same time. > > > > > > I prefer to add a separate option, too. > > > Depending on the comments, I'll either update doc for reinit_filter, or > add a > > > new option and related doc. > > > > Since there is an existed option named "autorotate", add an new option > "autoscale" looks can keep tune. > > I like the idea of having a new option, too. The option name "reinit_filter" > doesn't imply anything > about "scaling"... it's just a side-effect. That is, reinit_filter could > cause other > filters to behave > differently too, right? So an explicit option to enable/disable auto scale > would imply a more > obvious expectation to the user. >
Thanks for the comments. Will refine new patches with a separate option and doc. - linjie _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
