> -----Original Message----- > From: Li, Zhong > Sent: Wednesday, August 14, 2019 22:37 > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Cc: Fu, Linjie <linjie...@intel.com> > Subject: RE: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: provide > detailed warning if directly mapping fails > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > Behalf > > Of Linjie Fu > > Sent: Wednesday, August 14, 2019 5:25 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Fu, Linjie <linjie...@intel.com> > > Subject: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: provide detailed > > warning if directly mapping fails > > > > Detailed message could be helpful when using > > hwmap=mode=direct,format=xxx for both qsv and vaapi. > > > > Signed-off-by: Linjie Fu <linjie...@intel.com> > > --- > > libavutil/hwcontext_vaapi.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > Why just give a warning message when you need to return an error?
Previously these messages are hidden in the code, thus a warning info could be a more gentle improvement IMHO. (since there will be other error logs prompted when av_hwframe_map() fails) It sounds an error message is necessary. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
