On Sun, Sep 08, 2019 at 12:46:25AM +0300, Andrey Semashev wrote: > On 2019-09-07 18:32, Limin Wang wrote: > >On Sat, Sep 07, 2019 at 05:19:55PM +0200, Michael Niedermayer wrote: > >>On Wed, Aug 28, 2019 at 06:32:37PM +0300, Andrey Semashev wrote: > >>>Because lavf_container is sometimes called with only 2 arguments, > >>>fate tests produce bash errors like this: > >>> > >>> tests/fate-run.sh: 299: test: =: unexpected operator > >>> > >>>This commit fixes this. > >>>--- > >>> tests/fate-run.sh | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>I think this change is correct but shell is not my area ... > >If the $2 is two arguments between with space, the patch is needed. > > $2 is a single argument that may contain spaces. It is interpreted > as a single argument as long as it is enclosed in quotes in > lavf_container invokation. > > The problem is caused not by $2 but by the fact there is no $3. See > lavf_container_attach, lavf_container_timecode_nodrop, > lavf_container_timecode_drop and lavf_container_timecode functions, > as well as a few tests in tests/fate/lavf-container.mak. > > >Why I haven't got such errors when I'm running fate? > > I noticed the errors when the tests failed (due to my local changes > not relevant to this patch). I don't know the details about how > tests are run, but maybe the output is suppressed when the tests > pass? The patch looks good to me, but I don't have push access. Please ask for other developer to push it.
> _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
