Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorconstancy: fix overreads in gauss array

[Mina]

On 10/12/19 11:09 AM, Paul B Mahol wrote:

Fixes #8250

Signed-off-by: Paul B Mahol <one...@gmail.com>
---
  libavfilter/vf_colorconstancy.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavfilter/vf_colorconstancy.c b/libavfilter/vf_colorconstancy.c
index e3bb39e51b..cc081e957f 100644
--- a/libavfilter/vf_colorconstancy.c
+++ b/libavfilter/vf_colorconstancy.c
@@ -280,7 +280,7 @@ static int slice_get_derivative(AVFilterContext* ctx, void* 
arg, int jobnr, int
                      dst[INDX2D(r, c, width)] = 0;
                      for (g = 0; g < filtersize; ++g) {
                          dst[INDX2D(r, c, width)] += GAUSS(src, r,             
           c + GINDX(filtersize, g),
-                                                          in_linesize, height, 
width, gauss[GINDX(filtersize, g)]);
+                                                          in_linesize, height, 
width, gauss[g]);
                      }
                  }
              }
@@ -295,7 +295,7 @@ static int slice_get_derivative(AVFilterContext* ctx, void* 
arg, int jobnr, int
                      dst[INDX2D(r, c, width)] = 0;
                      for (g = 0; g < filtersize; ++g) {
                          dst[INDX2D(r, c, width)] += GAUSS(src, r + 
GINDX(filtersize, g), c,
-                                                          width, height, 
width, gauss[GINDX(filtersize, g)]);
+                                                          width, height, 
width, gauss[g]);
                      }
                  }
              }

LGTM

Thanks,
Mina

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".