> -----Original Message----- > From: Paul B Mahol [mailto:one...@gmail.com] > Sent: Monday, October 28, 2019 8:01 PM > To: Guo, Yejun <yejun....@intel.com> > Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing: add a > generic filter for image proccessing with dnn networks > > On 10/28/19, Paul B Mahol <one...@gmail.com> wrote: > > On 10/28/19, Guo, Yejun <yejun....@intel.com> wrote: > >> > >> > >>> -----Original Message----- > >>> From: Paul B Mahol [mailto:one...@gmail.com] > >>> Sent: Monday, October 28, 2019 4:00 PM > >>> To: FFmpeg development discussions and patches > <ffmpeg-devel@ffmpeg.org> > >>> Cc: Guo, Yejun <yejun....@intel.com> > >>> Subject: Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing: > >>> add > >>> a > >>> generic filter for image proccessing with dnn networks > >>> > >>> On 10/21/19, Guo, Yejun <yejun....@intel.com> wrote: > >>> > This filter accepts all the dnn networks which do image processing. > >>> > Currently, frame with formats rgb24 and bgr24 are supported. Other > >>> > formats such as gray and YUV will be supported next. The dnn network > >>> > can accept data in float32 or uint8 format. And the dnn network can ... > >>> > + > >>> > +typedef struct DnnProcessingContext { > >>> > + const AVClass *class; > >>> > + > >>> > + char *model_filename; > >>> > + DNNBackendType backend_type; > >>> > + enum AVPixelFormat fmt; > >>> > >>> This should be int. > >> > >> could you please help to explain a bit more why 'enum AVPixelFormat' > >> should > >> be int. > >> > >> I searched 'AV_OPT_TYPE_PIXEL_FMT' in vf_* files and found 'enum > >> AVPixelFormat' is used in > >> vf_mergeplanes.c, vf_program_opencl.c and vf_tonemap_opencl.c. > > > > That is error, I gonna fix mergeplanes ASAP. Sometimes enum may use > > completely another type, Michael may know more. > > Besides options assumes ints and not enums. > > Actually they take also enums, so it should be safe. So ignore this one. > Sorry.
got it, no problem, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".