On Tue, 17 Dec 2019, James Almer wrote:

On 12/17/2019 6:27 PM, Martin Storsjö wrote:
On Sun, 15 Dec 2019, Martin Storsjö wrote:

On Tue, 10 Dec 2019, Martin Storsjö wrote:

In these cases, we must pass the full path of the file to ffprobe
(as the current working dir on the remote system, e.g. when invoked
with "ssh remote ffprobe ..." isn't the wanted one).

The input filename passed to ffprobe is also included in the output,
which is part of the reference test data. Add a new option to
ffprobe to allow overriding what path is printed, to keep the
original relative path in the tests.

An alternative approach could be an option to allow requesting omitting
the file name from the dumped data, and updating the test references
accordingly.
---
fftools/ffprobe.c      | 22 ++++++++++++++++++----
tests/fate/ffprobe.mak |  2 +-
2 files changed, 19 insertions(+), 5 deletions(-)

Ping

If there's no opposition to this one, I'll push it tomorrow; it's been out
for review for over a week.

// Martin

Not against it, but there have been a couple new tests since you first
sent this, so better check they don't break, or require changes.

This change still works fine, and none of the new tests seem to require changes, at least not with respect to the aspects of this (and the other remaining one).

Thus pushed this one, and the checkasm one.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to