On 30/12/2019 23:53, James Almer wrote: >> Does multiplying by FF_QP2LAMBDA even make sense here? That contsant >> is for H.263's QP scale, not HEVC's. > > Pretty much every call to ff_side_data_set_encoder_stats() in lavc does > it, including libx264, so i figure it's expected.
It looks like it won't work for e.g. AV1, which has a QP (qindex) range of 0-255, for example, but will for current MPEG codecs which all have 0-51, so is fine in this patch. The documentation for FF_QP2LAMBDA is... let's call it lacking. Aside: libaom and libvpx passes ff_side_data_set_encoder_stats the SSE... gross (and WTF?). - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
