I doesn't look like there are any blockers on this patch request - could someone go ahead and merge it?
On Sat, Sep 28, 2019 at 2:55 AM Reino Wijnsma <rwijn...@xs4all.nl> wrote: > On 2019-09-27T19:37:40+0200, William Martin <unique.will.mar...@gmail.com> > wrote: > > On Wed, Sep 25, 2019 at 2:36 PM Reino Wijnsma <rwijn...@xs4all.nl> > wrote: > >> On 2019-09-25T20:57:08+0200, William Martin < > unique.will.mar...@gmail.com> > >> wrote: > >>> + av_log(s, AV_LOG_ERROR, "App field don't match up: %s <-> > %s. " > >> Although I'm not a native English speaker, since "field" isn't plural, > I'm pretty confident "don't" should be "doesn't". > >> > >> -- Reino > > > > Hi Reino - good point. Though, that was an existing log message that I > did > > not modify. Should the old typo be addressed in a separate patch, or > should > > I update it here? > > > I believe that's good practise here, yes. However, I'm not a FFmpeg coder, > so someone else would to correct me otherwise. > > Please don't top-post on this mailinglist! > > -- Reino > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
