Quoting James Almer (2020-02-26 01:28:48) > On 2/24/2020 6:54 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-02-20 17:26:00) > >> Signed-off-by: James Almer <jamr...@gmail.com> > > > > Commit message is now misleading since it will only enable prft if it's > > not disabled. > > Sorry, i pushed this during the weekend. And, true. It's still > attempting but technically not always... > > Which makes me realize i should mention this undocumented behavior in > the doxy. > > >> --- > >> Now it can be overriden if you explicitly set write_prft to 0. > >> > >> libavformat/dashenc.c | 8 +++++++- > >> 1 file changed, 7 insertions(+), 1 deletion(-) > >> > >> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > >> index a52cbc9113..7032adc84d 100644 > >> --- a/libavformat/dashenc.c > >> +++ b/libavformat/dashenc.c > >> @@ -1394,6 +1394,12 @@ static int dash_init(AVFormatContext *s) > >> c->frag_type = FRAG_TYPE_EVERY_FRAME; > >> } > >> > >> + if (c->write_prft < 0) { > >> + c->write_prft = c->ldash; > > > > nit: !!, in case ldash becomes something else than a bool in the future > > The chances for that are pretty slim, since turning a bool into an int > would be an API break (true/false would stop working from the command > line, afaik). But i can change it anyway.
I mean someone could do exactly the thing you are doing here - use -1 for default/unset. > > > > Otherwise LGTM. > > > > Thanks, and apologies for not waiting a bit more. No problem, I should have looked more closely before replying. They were minor comments anyway. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".