On 4/7/20, Anton Khirnov <an...@khirnov.net> wrote: > Quoting Paul B Mahol (2020-04-07 16:29:23) >> On 4/7/20, Anton Khirnov <an...@khirnov.net> wrote: >> > Quoting Paul B Mahol (2020-04-06 16:27:54) >> >> On 4/6/20, James Almer <jamr...@gmail.com> wrote: >> >> > On 4/6/2020 7:01 AM, Paul B Mahol wrote: >> >> >> On 3/20/20, Paul B Mahol <one...@gmail.com> wrote: >> >> >>> Signed-off-by: Paul B Mahol <one...@gmail.com> >> >> >>> --- >> >> >>> configure | 1 + >> >> >>> libavcodec/Makefile | 1 + >> >> >>> libavcodec/allcodecs.c | 1 + >> >> >>> libavcodec/avcodec.h | 1 + >> >> >>> libavcodec/bink2.c | 869 ++++++++++++++++++++++++++++ >> >> >>> libavcodec/bink2f.c | 1125 >> >> >>> ++++++++++++++++++++++++++++++++++++ >> >> >>> libavcodec/bink2g.c | 1197 >> >> >>> +++++++++++++++++++++++++++++++++++++++ >> >> >>> libavcodec/codec_desc.c | 7 + >> >> >>> libavformat/bink.c | 3 +- >> >> >>> 9 files changed, 3203 insertions(+), 2 deletions(-) >> >> >>> create mode 100644 libavcodec/bink2.c >> >> >>> create mode 100644 libavcodec/bink2f.c >> >> >>> create mode 100644 libavcodec/bink2g.c >> >> >>> >> >> >> >> >> >> Will apply soon! >> >> > >> >> > You need to first send an updated patch with the bug/leak fixes that >> >> > people reported applied, so it can be confirmed they are ok. >> >> >> >> I fixed all bugs. gonna apply ASAP! >> > >> > This behaviour is utterly unacceptable. >> > >> >> You wish, you ignore fact that I lost so much time in developing this >> decoder, > > "lost"? If you consider that time lost then why did you do it at all?
Because how would I know upfront that I would get so many negative reviews which mostly nitpick stuff around? > >> to need tolerate such bikesheds from "friendly" developers. > > Why should the other developers lose their time arguing with you? Or why > should they tolerate your constant blatantly belligerent behaviour. > > I should point out that reviewing is hard, time-consuming, unrewarded, > and underappreciated - yet incredibly important. You should be grateful > that people spend their time reading your code rather than attack or > disregard them. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".